-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Section updates #271
Merged
Merged
Section updates #271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes G-Node#267 reorder makes only sense in the scope of a section. Therefore it is moved from base to section proper.
In the previous set attribute order, the repository attribute was overwritten with None by the super.__init__ after it had been set.
The case of the single test in this testfile is covered by the 'append' test in test_section.
Appending multiple Sections or Properties has been removed to mirror Property append functionality and since extend already serves this need.
I tested the |
achilleas-k
approved these changes
Mar 28, 2018
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates Section methods and adds many tests.
reorder
is moved frombase
toSection
since it makes no sense to have it inDocument
orProperty
. Closes Refactorreorder()
method #267.extend
method for child Sections and Properties. Closes change value related behaviors #237.append
method to mirror Propertyappend
functionality and sinceextend
now serves this need.__init__
set attributes order: In the previous set attribute order, the repository attribute was overwritten withNone
by thesuper.__init__
after it had been set.strict
flag tomerge
method. Closes Add section.merge() strict keyword #270.parent = None
bugs inremove
andinsert
.name
check for existing child oninsert
.section
andsection
save/load tests.Don't be afraid, its mainly tests!