Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Terminology Cache #375

Merged
merged 6 commits into from
Apr 12, 2020
Merged

Terminology Cache #375

merged 6 commits into from
Apr 12, 2020

Conversation

fschrader1992
Copy link
Collaborator

@fschrader1992 fschrader1992 commented Apr 3, 2020 •
edited
Loading

This PR

@coveralls
Copy link

coveralls commented Apr 3, 2020 •
edited
Loading

Coverage Status

Coverage increased (+0.6%) to 76.383% when pulling c65ecaa on fschrader1992:rdf into d9d5223 on G-Node:master.

jgrewe
jgrewe approved these changes Apr 5, 2020
View reviewed changes
Copy link
Member

@jgrewe jgrewe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

mpsonntag
mpsonntag requested changes Apr 7, 2020
View reviewed changes
Copy link
Contributor

@mpsonntag mpsonntag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The added cache function is useful, but #202 requires a full refresh of the cache.

mpsonntag
mpsonntag requested changes Apr 10, 2020
View reviewed changes
Copy link
Contributor

@mpsonntag mpsonntag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor change, looks good otherwise, thanks!

@fschrader1992
Copy link
Collaborator Author

Checks for Code Quality:

  • Pylint
  • Rebase onto GNODE Master
  • Repeat Local Tests Python3.8
  • Repeat Local Tests Python2.7

@mpsonntag mpsonntag merged commit 7dde867 into G-Node:master Apr 12, 2020
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@mpsonntag mpsonntag mpsonntag requested changes

@jgrewe jgrewe jgrewe approved these changes

@achilleas-k achilleas-k achilleas-k approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Comparison of odml objects [1.4] Terminology cache cannot be refreshed
5 participants
@fschrader1992 @coveralls @jgrewe @achilleas-k @mpsonntag