Moving get universe out of start method #188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
this one is ready for review if anyone has time |
shimwell
changed the title
psauvan
pushed a commit
that referenced
this pull request
Jun 17, 2024
* moved two methods out of start * removed unnecessary logger line * calculating bb if still None * improved comment * private method for now
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Simple PR that moves some more logic from the start() method, this time we are moving the bounding box calculation outside. While doing this I noticed there was a hard coded parameter of 10 used for enlarging the bounding box. So I've added that as an argument. One benefit of #184 would be ease of exposing these options to the user.
Fixes issue
Please link to any issues that this PR fixes
Checklist