Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

volume tests - reduced number of skipped models #63

Merged
merged 1 commit into from
Apr 23, 2024
Merged

volume tests - reduced number of skipped models #63

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tests/test_convert.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ def test_conversion(input_step_file):
"cellSummaryFile = False\n"
"cellCommentFile = False\n"
"debug = False\n"
"simplify = full\n"
"simplify = no\n"
"[Options]\n"
"forceCylinder = False\n"
"splitTolerance = 0\n"
Expand Down
15 changes: 2 additions & 13 deletions tests/test_volumes.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,20 +31,9 @@

path_to_cad = Path("testing/inputSTEP")
step_files = list(path_to_cad.rglob("*.stp")) + list(path_to_cad.rglob("*.step"))

# this checks if the tests are being run a github action runner or not
step_files.remove(Path('testing/inputSTEP/Misc/rails.stp'))
# # this checks if the tests are being run a github action runner or not
if os.getenv("GITHUB_ACTIONS"):
# removing the larger models and models where the volumes don't match from
# some of these step file are removed as it fails the volume tests.
# Perhaps a bug with torus conversion or a bug with the stp file?
# Issue raised https://github.com/GEOUNED-org/GEOUNED/issues/55
step_files.remove(Path('testing/inputSTEP/Misc/rails.stp'))
step_files.remove(Path('testing/inputSTEP/placa.stp'))
step_files.remove(Path('testing/inputSTEP/Misc/tester.stp'))
step_files.remove(Path('testing/inputSTEP/large/SCDR.stp'))
step_files.remove(Path('testing/inputSTEP/large/Triangle.stp'))
step_files.remove(Path('testing/inputSTEP/Torus/face2.stp'))
step_files.remove(Path('testing/inputSTEP/Torus/rueda.stp'))
# reduced samples as github action runners have 2 threads and more samples
# is not needed for the smaller models tested. This allows the CI to
# quickly test the smaller models
Expand Down