feat: topic specific thresholds #384
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthiasschaub
added
waiting
matthiasschaub
force-pushed
the
thresholds
branch
2 times, most recently
from
b487d04 to
0fef807
Compare
matthiasschaub
force-pushed
the
thresholds
branch
from
0fef807 to
a851ae9
Compare
matthiasschaub
removed
the
waiting
`get_valid_layer()` result will filter out None values.
…all indicator-layer-combinations
matthiasschaub
commented
Oct 20, 2022
Comment on lines
+28
to
+37
| jrc_airport_count: null | ||
| jrc_bridge_count: null | ||
| jrc_cultural_heritage_site_count: null | ||
| jrc_education_count: null | ||
| jrc_health_count: null | ||
| jrc_mass_gathering_sites_count: null | ||
| jrc_power_generation_plant_count: null | ||
| jrc_railway_count: null | ||
| jrc_road_count: null | ||
| jrc_water_treatment_plant_count: null |
There was a problem hiding this comment.
I think those layers are not beein used at the moment. Lets not add them here for now.
matthiasschaub
commented
Oct 20, 2022
Comment on lines
+40
to
+44
| mapaction_lakes_count: null | ||
| mapaction_major_roads_length: null | ||
| mapaction_rail_length: null | ||
| mapaction_rivers_length: null | ||
| mapaction_settlements_count: null |
There was a problem hiding this comment.
Same as above comment
matthiasschaub
commented
Oct 20, 2022
| self, | ||
| layer: Layer, | ||
| feature: Feature, | ||
| thresholds: Optional[Tuple[float, float, float, float]] = None, |
There was a problem hiding this comment.
For this indicator its actualy a tuple of dicts (see in the layer-thresholds in the metadata:
[big-data/ohsome](default: [{ a: 1000 }, null, { a: 500 }, null])
Here we also need to check the threshold function used by this indicator to use the threshold function parameter
matthiasschaub
commented
Oct 20, 2022
| @@ -26,4 +26,5 @@ GhsPopComparisonRoads: | |||
| $feature_length_per_sqkm km of roads per sqkm mapped. | |||
| layer-thresholds: | |||
| default: [{ a: 1000 }, null, { a: 500 }, null] | |||
| major_roads_length: null | |||
| jrc_road_length: null | |||
There was a problem hiding this comment.
Lets not include JRC layers here
matthiasschaub
commented
Oct 20, 2022
Comment on lines
+23
to
+27
| jrc_education_count: null | ||
| jrc_health_count: null | ||
| jrc_mass_gathering_sites_count: null | ||
| jrc_railway_length: null | ||
| jrc_road_length: null |
There was a problem hiding this comment.
Same as before
matthiasschaub
commented
Oct 20, 2022
Comment on lines
+30
to
+34
| mapaction_lakes_area: null | ||
| mapaction_major_roads_length: null | ||
| mapaction_rail_length: null | ||
| mapaction_rivers_length: null | ||
| mapaction_settlements_count: null |
There was a problem hiding this comment.
Same as before
matthiasschaub
commented
Oct 20, 2022
Comment on lines
+23
to
+30
| jrc_airport_count: null | ||
| jrc_bridge_count: null | ||
| jrc_cultural_heritage_site_count: null | ||
| jrc_education_count: null | ||
| jrc_health_count: null | ||
| jrc_mass_gathering_sites_count: null | ||
| jrc_power_generation_plant_count: null | ||
| jrc_road_length: null |
There was a problem hiding this comment.
Same as before
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please add a clear and concise description of what your PR solves.
Corresponding issue
#21
New or changed dependencies
Checklist
main(e.g. throughgit rebase main)