Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: custom attribute filter is now combined with topic filter #865

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

Gigaszi
Copy link
Collaborator

@Gigaszi Gigaszi commented Dec 19, 2024

Checklist

  • I have ensured my branch is mergeable with main (e.g. through git rebase main if necessary)
  • My code follows the style guide and was checked with pre-commit before committing
  • I have commented my code
  • I have added sufficient unit and integration tests
  • I have added new Hurl regression tests and checked all existing tests
  • I have updated the CHANGELOG.md

@mmerdes mmerdes self-requested a review December 20, 2024 10:31
Copy link
Collaborator

@mmerdes mmerdes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR with the fix.

If I am not mistaken the test introduced in this commit:
6a453e2

got removed again accidentally in a later commit.
Please check again.

Maybe this would also be a good opportunity to fix the spelling of 'atribute' in some file names as some of these files were touched in this PR.
What do you think?

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants