Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

feat(SBE-562): OICP 2.3.0 client #1

Merged
merged 3 commits into from
Jun 5, 2023
Merged

feat(SBE-562): OICP 2.3.0 client #1

merged 3 commits into from
Jun 5, 2023

Conversation

radekkrejcirik01
Copy link
Contributor

YouTrack task
SBE-562

Adding:

  • Feature
  • Bug fix
  • Test coverage

Why is this change required?

  • We need to generate OICP 2.3.0 client library for our implementation

What changed?

  • Generated client using oapi-codegen generator

Additional info for reviewers

  • I had to rename the types of OperatorId to OperatorIdType and ProviderId to ProviderIdType because they had duplicate names to parameters

@radekkrejcirik01 radekkrejcirik01 added documentation Improvements or additions to documentation enhancement New feature or request labels Jun 5, 2023
@radekkrejcirik01 radekkrejcirik01 self-assigned this Jun 5, 2023
@radekkrejcirik01 radekkrejcirik01 requested a review from xBlaz3kx June 5, 2023 11:06
xBlaz3kx
xBlaz3kx suggested changes Jun 5, 2023
View reviewed changes
2.3.0/README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@radekkrejcirik01 radekkrejcirik01 requested a review from xBlaz3kx June 5, 2023 12:15
@radekkrejcirik01 radekkrejcirik01 merged commit 32d6d54 into main Jun 5, 2023
@radekkrejcirik01 radekkrejcirik01 deleted the feature/SBE-562-oicp-client branch June 5, 2023 12:31
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@xBlaz3kx xBlaz3kx xBlaz3kx approved these changes

Assignees

@radekkrejcirik01 radekkrejcirik01

Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@radekkrejcirik01 @xBlaz3kx