Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

feat(TRIVIAL): Charging notifications request body #3

Merged
merged 1 commit into from
Jul 4, 2023
Merged

feat(TRIVIAL): Charging notifications request body #3

merged 1 commit into from
Jul 4, 2023

Conversation

radekkrejcirik01
Copy link
Contributor

Adding:

  • Feature
  • Bug fix
  • Test coverage

Why is this change required?

  • The OpenAPI specification uses oneOf for start, progress, end and error schemas. In generated result the request body doesn't have properties and the type is unusable

What changed?

  • Changed the oneOf to allOf and removed required types in schemas

@radekkrejcirik01 radekkrejcirik01 added the bug Something isn't working label Jul 4, 2023
@radekkrejcirik01 radekkrejcirik01 self-assigned this Jul 4, 2023
@radekkrejcirik01 radekkrejcirik01 merged commit 8a51c63 into main Jul 4, 2023
@radekkrejcirik01 radekkrejcirik01 deleted the feature/SBE-562-oicp-client branch July 4, 2023 12:58
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@aljazmark aljazmark aljazmark approved these changes

Assignees

@radekkrejcirik01 radekkrejcirik01

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@radekkrejcirik01 @aljazmark