Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

"Loading" and "No data" messages #286

Open
garrettjstevens opened this issue Sep 21, 2023 · 1 comment · May be fixed by #303
Open

"Loading" and "No data" messages #286

garrettjstevens opened this issue Sep 21, 2023 · 1 comment · May be fixed by #303
Assignees
@carolinebridge

Comments

@garrettjstevens
Copy link
Contributor

In the graphical display and the tabular display, it would be good to have a "Loading" message while the data is being loaded so the user knows that something is happening.

When the loading is finished, if there is no data to show in the displayed area, the tabular display should also show a "No data in this region" or some sort of other message.

May need to add a loading status flag to the client data store.
@garrettjstevens
Copy link
Contributor Author

Possible implementation for loading message:

  • Add "loadingRegions" as a Region[] to volatile section of packages/jbrowse-plugin-apollo/src/session/ClientDataStore.ts
  • In loadFeatures in that same file, add currently loading region to "loadingRegions" at the beginning of the action and remove it at the end
  • In packages/jbrowse-plugin-apollo/src/LinearApolloDisplay/components/LinearApolloDisplay.tsx, check the currently loading regions (via session.apolloDataStore.loadingRegions) and the displayed regions (via model.displayedRegions), and if any of them overlap, add a "Loading..." message to the component
    • The loading message can be in the corner of the track and overlap the regular track area, since it may still be loading new data when there is already data on the screen

I'll have to think more about the "No data" message

@carolinebridge carolinebridge linked a pull request Oct 13, 2023 that will close this issue
Open
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@carolinebridge carolinebridge

Labels
None yet
Projects
Apollo 3
Status: No status
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Adds "loading" and "no data" messages to graphical and tabular displays when relevant GMOD/Apollo3
2 participants
@garrettjstevens @carolinebridge