-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
GPII-4218: Send UIO+ settings to Morphic #52
base: master
Are you sure you want to change the base?
Conversation
Cheers - I assume this will be updated in the light of fluid-project/uio-plus#17 |
@amb26 thanks for merging that. I'll make a new dev release of UIO+ and update this PR with that. However, it won't really affect the code, as I've re-implemented the |
Currently we do not provide any special handling for these messags other than relaying into an event. However, this is a rough in implementation in case we require to wait for or in some other way respond to these confirmations.
@amb26 given the state of Morphic Classic, should we tag and create GitHub release before merging this PR? |
Yes, please issue a release and indicate in its release notes that it is the last release compatible with the last official release of Morphic Classic, 1.3.5 |
@amb26 I've tagged and created a GitHub Release. I didn't bother publishing to the Chrome Web Store because that will get overwritten with what we publish after this PR is merged. |
@amb26 I bumped the version number to "0.2.0" as I figure this will be the last release and will drop the beta from tags and etc. If you think I should keep with the beta versioning I can switch it up. see: Manifest - Version |
@amb26 when you review this PR, could you also update the description of the repository? I don't seem to have access to do that. Could you please change "UI Options Plus Chrome Extension" to be "UIO+ For Morphic"? |
https://issues.gpii.net/browse/GPII-4218
Requires changes to Universal for accepting the settings from UIO+ for Morphic.