[342] Delete assignments and evaluations when an evaluator is deleted #404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… when evaluator is removed from a challenge phase
6 tasks
emmabjj
deleted the
342_delete_assignments_evaluations_on_evaluator_deletion
branch
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linked ticket: #112 #342
AC: When an Evaluator is removed from a Challenge phase, we need to remove the other associations if they exist.
Currently the EvaluatorManagementService is only deleting the ChallengePhaseEvaluator, however it should also delete any EvaluatorSubmissionAssignment and Evaluation records associated with that user, if any exist.
Note: Given that EvaluatorSubmissionAssignment has
has_one :evaluation, dependent: :destroy, when destroy_all is called on the assignments, it will trigger the dependent destroy callback and delete the associated evaluation as well.