backport #1911 to GNOME 43 (based on v54) #1928
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
OK, now that we have CI images tagged |
refactor(core): update certificate generation
Update the certificate generation to produce EC-based certificates
with the required device ID format.
refactor(core): reject invalid device IDs
Check incoming device IDs and reject connections from those with
an ID not matching `/[a-zA-Z0-9_]{32,38}/`.
refactor(device): generate device IDs per protocol v8
refactor(core): migrate installations to new certificates
Migrate installations to new certificates, with device IDs
following the protocol v8 constraints.
test: update certificates and private keys
feat(daemon): add migration notification
Add a brief notification, explaining that GSConnect has been
updated and some devices may require re-pairing.
device: support protocol v8 verification key
See: https://invent.kde.org/network/kdeconnect-meta/-/merge_requests/10
feat: add support for protocol version 8
Add support for the planned changes in protocol version 8.
See: https://invent.kde.org/network/kdeconnect-android/-/commit/454b2fd5d7b3162443fbec4a6f0b7cafa1b554ee
ferdnyc
force-pushed
the
backport-proto8-v54
branch
from
9473ef6 to
e2539b3
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It will, frankly, be a miracle if I haven't missed or broken anything here, and presumably the CI will need some major adjusting just to be able to test these, but:
This PR is an attempt to bring all of the changes from #1911 to the
backports/gnome-43branch, which is based off of tagv54(the last GNOME 43 release of GSConnect).For release as
v59, to be followed bybackports/gnome-45asv60, thenmainasv61.