Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Refactor Plane. Add validity check. #195

Merged
merged 1 commit into from
Jul 18, 2021
Merged

Refactor Plane. Add validity check. #195

merged 1 commit into from
Jul 18, 2021

Conversation

d3ssy
Copy link
Collaborator

@d3ssy d3ssy commented Jul 17, 2021

Closes #189

@d3ssy d3ssy added geometry refactor 🧰 Pull requests that perform maintenance on the project but add no features or bug fixes. labels Jul 17, 2021
sonomirco
sonomirco approved these changes Jul 17, 2021
View reviewed changes
Copy link
Collaborator

@sonomirco sonomirco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two empty lines to remove, and where we have summaries with more than one line can we use
I think, it makes the documentation more readable.

@d3ssy d3ssy merged commit b9a067e into develop Jul 18, 2021
@sonomirco sonomirco deleted the dev/guma/plane-flip branch July 19, 2021 06:39
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@sonomirco sonomirco sonomirco approved these changes

Assignees
No one assigned
Labels
refactor 🧰 Pull requests that perform maintenance on the project but add no features or bug fixes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PlaneFlip
2 participants
@d3ssy @sonomirco