Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Join returning a PolyCurve. #352

Merged
merged 3 commits into from
Sep 9, 2021
Merged

Conversation

sonomirco
Copy link
Collaborator

What type of PR is this? (check all applicable)

  • ♻️ Refactor
  • ✨ Feature
  • 🐛 Bug Fix
  • 👷 Optimization
  • 📝 Documentation Update
  • 🔖 Release
  • 🚩 Other

Description

This PR replaces the returning type of the method Join with PolyCurve.
Also:

  1. Added the documentation example into the PolyCurveTests.
  2. Fixed some typos and added comments.

Related Tickets & Documents

This PR closes #348

Added tests?

  • 👍 yes
  • 🙅 no, because they aren't needed
  • 🙋 no, because I need help

Added to documentation?

  • 📓 docs
  • 🙅 no documentation needed

Added example into PolyCurveTest class.
Correct some typo and added comments.
@sonomirco sonomirco added the refactor 🧰 Pull requests that perform maintenance on the project but add no features or bug fixes. label Sep 9, 2021
@sonomirco sonomirco self-assigned this Sep 9, 2021
@cesarecaoduro cesarecaoduro merged commit 336352c into develop Sep 9, 2021
@sonomirco sonomirco deleted the dev/mibi/join-return-a-polycurve branch October 6, 2021 09:34
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
refactor 🧰 Pull requests that perform maintenance on the project but add no features or bug fixes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Join return a PolyCurve
2 participants