Area of a triangle #399
Area of a triangle #399
Conversation
sonomirco
added
enhancement 📢
src/GShark/Core/Trigonometry.cs
Outdated
| /// <returns>The area of the triangle.</returns> | ||
| public static double AreaOfTriangle(PolyLine polyLine) | ||
| { | ||
| var pts = polyLine.ControlPointLocations; |
There was a problem hiding this comment.
Shouldn't we do some check on the number of vertices for the polyline?
There was a problem hiding this comment.
I assumed that if you calculate a triangle's area, you are passing a Polyline composed of 4 points.
We may not need this overload method.
There was a problem hiding this comment.
I think is still valid to keep it, as long as we introduce a check on the number of control points, and that first and last point are coincident (or polyline is closed)
There was a problem hiding this comment.
This method should be more specific given the name. It should take 3 points as parameters only. Using the vector based method for the area it shouldn't require any collinearity or coplanarity checks.
There was a problem hiding this comment.
I'll remove this overload for now.
|
@d3ssy @cesarecaoduro ready to be merged. |
What type of PR is this? (check all applicable)
Description
This PR added the faction to calculate the area of a triangle.
Related Tickets & Documents
This PR closes #398
Added tests?
Added to documentation?