Fix max_folder_size not working for smaller worlds
#172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lyfts <127234178+Lyfts@users.noreply.github.com>
Caedis
approved these changes
Jan 3, 2025
|
Was wondering if that method was rounding to the nearest gb |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
max_folder_sizesize option worked fine if you happen to have a world larger than 1gb, but didn't work at all for smaller worlds asFileUtils.getSize(file, SizeUnit.GB)would return 0. This changes it to just deal with the sizes in bytes which is the more sane way to do it anyways.Closes GTNewHorizons/GT-New-Horizons-Modpack#18613