Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Properly inform of disabled buttons #61

Merged
merged 3 commits into from
Apr 2, 2024

Conversation

Lyfts
Copy link
Member

@Lyfts Lyfts commented Apr 2, 2024

Addresses the confusion here: https://discord.com/channels/181078474394566657/401118216228831252/1224710621824553093

The buttons won't be hidden anymore but will instead be slightly grayed out and display a message informing that they're disabled.
disabled_server
And if the player is playing singleplayer the buttons will inform that they're disabled in config rather than by the server.
This has also been applied to the changes in #52
disabled_sp
The buttons can of course still be turned off in sidebar config.

@Lyfts Lyfts requested a review from a team April 2, 2024 15:52
Copy link
Member

@chochem chochem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yea, that's a good solution.

@evgengoldwar
Copy link

Now there will be no confusion for beginners

@Lyfts Lyfts merged commit 7315fc2 into GTNewHorizons:master Apr 2, 2024
1 check passed
@Lyfts Lyfts deleted the greyed-buttons branch April 2, 2024 16:22
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants