Skip to content

Commit

Permalink
Ran solution-wide formatting fix
Browse files Browse the repository at this point in the history
  • Loading branch information
jamie-taylor-rjj committed Dec 30, 2024
1 parent 8c951b8 commit d8903b6
Show file tree
Hide file tree
Showing 6 changed files with 18 additions and 18 deletions.
4 changes: 2 additions & 2 deletions src/Constants.cs
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,8 @@ public static class Constants
public const string ExpectCtHeaderName = "Expect-CT";

public const string CrossOriginResourcePolicyHeaderName = "Cross-Origin-Resource-Policy";

public const string CrossOriginOpenerPolicyHeaderName = "Cross-Origin-Opener-Policy";

public const string CrossOriginEmbedderPolicyHeaderName = "Cross-Origin-Embedder-Policy";
}
2 changes: 1 addition & 1 deletion src/Extensions/SecureHeadersMiddlewareBuilder.cs
Original file line number Diff line number Diff line change
Expand Up @@ -339,7 +339,7 @@ public static SecureHeadersMiddlewareConfiguration UseCrossOriginOpenerPolicy(
config.CrossOriginOpenerPolicy = new CrossOriginOpenerPolicy(value);
return config;
}

/// <summary>
/// The HTTP Cross-Origin-Embedder-Policy (COEP) response header configures embedding
/// cross-origin resources into the document.
Expand Down
4 changes: 2 additions & 2 deletions src/Models/SecureHeadersMiddlewareConfiguration.cs
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ public class SecureHeadersMiddlewareConfiguration
/// Indicates whether the response should use Cross-Origin-Opener-Policy
/// </summary>
public bool UseCrossOriginOpenerPolicy { get; set; }

/// <summary>
/// Indicates whether the response should use Cross-Origin-Embedder-Policy
/// </summary>
Expand Down Expand Up @@ -125,7 +125,7 @@ public class SecureHeadersMiddlewareConfiguration
public CrossOriginResourcePolicy CrossOriginResourcePolicy { get; set; }

public CrossOriginOpenerPolicy CrossOriginOpenerPolicy { get; set; }

public CrossOriginEmbedderPolicy CrossOriginEmbedderPolicy { get; set; }

/// <summary>
Expand Down
2 changes: 1 addition & 1 deletion src/SecureHeadersMiddleware.cs
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,7 @@ private FrozenDictionary<string, string> GenerateRelevantHeaders()
temporaryDictionary.Add(Constants.CrossOriginOpenerPolicyHeaderName,
_config.CrossOriginOpenerPolicy.BuildHeaderValue());
}

if (_config.UseCrossOriginEmbedderPolicy)
{
if (!_config.UseCrossOriginResourcePolicy)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ public async Task When_UseCrossOriginOpenerPolicyCalled_Header_Is_Present()
Assert.Equal(CrossOriginOpenerPolicy.SameOriginValue,
_context.Response.Headers[Constants.CrossOriginOpenerPolicyHeaderName]);
}

[Fact]
public async Task When_UseCrossOriginEmbedderPolicyCalled_Header_Is_Present()
{
Expand All @@ -56,16 +56,16 @@ public async Task When_UseCrossOriginEmbedderPolicyCalled_Header_Is_Present()
// assert
Assert.True(headerPresentConfig.UseCrossOriginEmbedderPolicy);
Assert.True(headerPresentConfig.UseCrossOriginResourcePolicy);

Assert.True(_context.Response.Headers.ContainsKey(Constants.CrossOriginResourcePolicyHeaderName));
Assert.Equal(CrossOriginResourcePolicy.SameOriginValue,
_context.Response.Headers[Constants.CrossOriginResourcePolicyHeaderName]);

Assert.True(_context.Response.Headers.ContainsKey(Constants.CrossOriginEmbedderPolicyHeaderName));
Assert.Equal(CrossOriginEmbedderPolicy.RequireCorp,
_context.Response.Headers[Constants.CrossOriginEmbedderPolicyHeaderName]);
}

[Fact]
public async Task When_UseCrossOriginEmbedderPolicyCalled_But_UseCrossOriginResourcePolicy_NotSupplied_Header_Is_Not_Present()
{
Expand All @@ -81,10 +81,10 @@ public async Task When_UseCrossOriginEmbedderPolicyCalled_But_UseCrossOriginReso
// assert
Assert.NotNull(exception);
Assert.IsType<ArgumentException>(exception);

Assert.True(headerPresentConfig.UseCrossOriginEmbedderPolicy);
Assert.False(headerPresentConfig.UseCrossOriginResourcePolicy);

Assert.False(_context.Response.Headers.ContainsKey(Constants.CrossOriginEmbedderPolicyHeaderName));
}

Expand Down Expand Up @@ -119,7 +119,7 @@ public async Task When_UseCrossOriginOpenerPolicyNotCalled_Header_Not_Present()
Assert.False(headerNotPresentConfig.UseCrossOriginOpenerPolicy);
Assert.False(_context.Response.Headers.ContainsKey(Constants.CrossOriginOpenerPolicyHeaderName));
}

[Fact]
public async Task When_UseCrossOriginEmbedderPolicyNotCalled_Header_Not_Present()
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,23 +7,23 @@ public void TrueValue_ShouldNotThrow_ArgumentException()
{
// Arrange
var argName = Guid.NewGuid().ToString();

// Act
var exception = Record.Exception(() => Guards.BoolValueGuardClauses.MustBeTrue(true, argName));

// Assert
Assert.Null(exception);
}

[Fact]
public void FalseValue_ShouldThrow_ArgumentException()
{
// Arrange
var argName = Guid.NewGuid().ToString();

// Act
var exception = Record.Exception(() => Guards.BoolValueGuardClauses.MustBeTrue(false, argName));

// Assert
Assert.NotNull(exception);
Assert.IsType<ArgumentException>(exception);
Expand Down

0 comments on commit d8903b6

Please # to comment.