Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

CLI info messages update #147

Merged
merged 1 commit into from
Jan 10, 2025

Conversation

scripnichenko
Copy link
Contributor

@scripnichenko scripnichenko commented Jan 4, 2025

Addressing issue #146

Copy link
Contributor

juntao commented Jan 4, 2025

Hello, I am a code review agent on flows.network. Here are my reviews of changed source code files in this PR.


install.sh

Potential issues

  1. Incorrect Backup Directory Handling: The script incorrectly attempts to change the directory to a file path in the --backup option, causing errors if the backup path is not a valid directory.

    backup_to_file=$(cd "$backup_to_file" && pwd)
  2. Redundant Installation URL Checks: The installation script redundantly checks for the repo_branch variable when downloading several files, leading to potential download errors if the branch does not match expected values.

    if [ "$repo_branch" = "main" ]; then
        check_curl https://github.com/GaiaNet-AI/gaianet-node/releases/download/$version/gaianet $bin_dir/gaianet
    else
        check_curl https://github.com/GaiaNet-AI/gaianet-node/raw/$repo_branch/gaianet $bin_dir/gaianet
    fi
  3. Error in Directory Check for frpc.toml: The script checks the wrong directory path when migrating frpc.toml, which may lead to failure if the correct file is not found.

    elif [ -f "$migrated_from_file" ] && ( tar -tf "$migrated_from_file" | grep -q "gaianet-domain/frpc.toml" || tar -tf "$migrated_from_file" | grep -q "gaia-frp/frpc.toml" ); then
        if tar -tf "$migrated_from_file" | grep -q "gaianet-domain/frpc.toml"; then
            tar -xf "$migrated_from_file" --strip-components=1 -C $gaianet_base_dir/gaia-frp gaianet-domain/frpc.toml
        else
            tar -xf "$migrated_from_file" --strip-components=1 -C $gaianet_base_dir/gaia-frp gaia-frp/frpc.toml
        fi

Summary of changes

  • • Updated the success completion messages with checkmark emojis () for both upgrade and installation.
  • Replaced generic arrows (>>>) with finger-pointing emojis (👉) to guide users on the next step.
  • Added sparkles around the node ID in the registration message (✨ $subdomain 🌟) to highlight it.

@scripnichenko scripnichenko changed the title updated messages CLI info messages update Jan 4, 2025
@alabulei1 alabulei1 merged commit efa8f40 into GaiaNet-AI:main Jan 10, 2025
1 check passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants