-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
v3.0.0 #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
95faf2b
to
1a03bf9
Compare
Could this be |
in case you proposing that |
Definitely the former :) |
This issue occurred irrelevant, but still worth adding tests for it
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of issues with generics and unnamed initializations linter have been completely refactored - it is easier to treat it a ground-up new linter:
WithStack
traversal - it is simplified and improved detection of structure being initialized within return statement.fix: Generic struct is ignored #39
close: fix: validate generics #40
fix: exhaustruct doesn't detect properties not defined in slice expressions #32
Previously: type is matched even if match is partial.
Now: type is matched only if it is a full match of full type name (including the package name).
Previously: analyzer constructor exposed on
/pkg/analyzer
subpath.Now: analyzer constructor exposed on
/analyzer
subpath.Previously: nested structures initialization within error-containing return have been allowed to stay unintialized.
pkgName.typ2 is missing field A
Previously:
A, B, C, D ..., Z are missing in TestType
Now:
pkgName.TestType is missing fields A, B, C, D ..., Z