fix(reporting): average open price should not be zero #1513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebastienverreault
approved these changes
Feb 28, 2025
When the collateral change is 0 the average open price UDF returns 0 this caused the alt collateral dashboard to show a price below the lowest price seen for the average open price when taking the average over credit facilities (since some were set to 0 instead of NULL)
jireva
force-pushed
the
reporting-fix-zero-avg-open-price
branch
from
0a68918 to
99ef11e
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the collateral change is 0 the average open price UDF returns 0 this caused the alt collateral dashboard to show a price below the lowest price seen for the average open price when taking the average over credit facilities (since some were set to 0 instead of NULL)