Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Upgrades to node & base images for node and python #357

Merged
merged 3 commits into from
May 4, 2023
Merged

Conversation

davidwilby
Copy link
Contributor

Maintenance has ended for v14 and v18 is the current LTS version of node.

@github-actions
Copy link

github-actions bot commented May 4, 2023

Jest Coverage

File % Stmts % Branch % Funcs % Lines Uncovered Line #s
All files 86.66 85.45 53.33 86.66
File % Stmts % Branch % Funcs % Lines Uncovered Line #s
All files 86.66 85.45 53.33 86.66
_jrpc 94.04 91.66 83.33 94.04
_ index.js 94.04 91.66 83.33 94.04 29-30,38-40
_utils 83.98 83.72 33.33 83.98
_ annotations.js 97.72 73.91 100 97.72 35-36
_ dict.js 88.88 83.33 100 88.88 3-4
_ index.js 73.6 100 14.28 73.6 9-17,28-29,43-53,64-65,76-82,93-94

@davidwilby davidwilby changed the title upgrade to node 18 Upgrades to node & base images for node and python May 4, 2023
@ianroberts
Copy link
Member

LGTM now, I guess rebase #356 once this has merged.

@davidwilby
Copy link
Contributor Author

davidwilby commented May 4, 2023

LGTM now, I guess rebase #356 once this has merged.

That's the plan! Thanks!

@davidwilby davidwilby merged commit 8b52ed3 into dev May 4, 2023
@davidwilby davidwilby deleted the node18 branch May 4, 2023 09:21
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants