Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Migrate screenshot workflow to playground/cli (Attempt: 2) #838

Conversation

carstingaxion
Copy link
Collaborator

@carstingaxion carstingaxion commented Sep 2, 2024

Description of the Change

Use WordPress Playground in favor of wp-env as the environment for the screenshot generator.

Switching to Playground not only makes this workflow a lot faster, it also allows to use a blueprint.json to setup the environment, which is way more comfortable, than writing a long list of wp-cli commands to do the same.

Needed before merge

Included in this PR is also:

  • the subtle change to use the modern Admin-UI,
    which should become the default across all GatherPress Playgrounds
  • hiding the admin-notices for this presentation-purpose, like @patriciabt suggested
  • fixing the left sided menu background to fill the full height of the screen

grafik

Closes #

How to test the Change

Changelog Entry

Changed - Run the screenshot generator workflow on WordPress Playground

Credits

Props @carstingaxion

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@mauteri mauteri merged commit 1fad80a into GatherPress:main Sep 2, 2024
8 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants