-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Migrate screenshot workflow to playground/cli (Attempt: 2) #838
Merged
mauteri
merged 28 commits into
GatherPress:main
from
carstingaxion:try/migrate-screenshot-workflow-to-playground-cli-2
Sep 2, 2024
Merged
Migrate screenshot workflow to playground/cli (Attempt: 2) #838
mauteri
merged 28 commits into
GatherPress:main
from
carstingaxion:try/migrate-screenshot-workflow-to-playground-cli-2
Sep 2, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… heigt of the page
…start localized playgrounds
… been triggered on the last run)
…d before the tests start
This was referenced Sep 2, 2024
mauteri
approved these changes
Sep 2, 2024
4 tasks
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
Use WordPress Playground in favor of
wp-env
as the environment for the screenshot generator.Switching to Playground not only makes this workflow a lot faster, it also allows to use a
blueprint.json
to setup the environment, which is way more comfortable, than writing a long list ofwp-cli
commands to do the same.Needed before merge
Included in this PR is also:
which should become the default across all GatherPress Playgrounds
Closes #How to test the Change
Changelog Entry
Credits
Props @carstingaxion
Checklist: