Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add PHPUnit 7.0 conflict #56

Merged
merged 1 commit into from
Feb 5, 2018
Merged

Conversation

Slamdunk
Copy link
Contributor

@Slamdunk Slamdunk commented Feb 5, 2018

Fatal error: Declaration of GeckoPackages\PHPUnit\Constraints\SameStringsConstraint::additionalFailureDescription($other) must be compatible with PHPUnit\Framework\Constraint\Constraint::additionalFailureDescription($other): string in ./vendor/gecko-packages/gecko-php-unit/src/PHPUnit/Constraints/SameStringsConstraint.php on line 43

@SpacePossum SpacePossum merged commit 8b03201 into GeckoPackages:3.0 Feb 5, 2018
@SpacePossum
Copy link
Member

thank you @Slamdunk

@Slamdunk Slamdunk deleted the patch-1 branch February 5, 2018 09:19
@Slamdunk
Copy link
Contributor Author

Slamdunk commented Feb 5, 2018

May I ask you if you are going to build a bugfix release for this?

@SpacePossum
Copy link
Member

👍
I've released v3.1.1 with your fix.

@Slamdunk
Copy link
Contributor Author

Slamdunk commented Feb 5, 2018

Thank you

@Slamdunk
Copy link
Contributor Author

Slamdunk commented Feb 5, 2018

For your interest: this patch was needed, but a bit useless because Composer dependency tree resolution installs v3.0.0 or v3.1.0 which don't provide this conflict.
Don't know if it can be solved in any method different from overriding already released tags 😦

@SpacePossum
Copy link
Member

lets see why composer doesn't up to 3.1, IIRC there not much of a reason not to update to 3.1

@ndench
Copy link

ndench commented Feb 9, 2018

Is there any reason why this limit allow up to but not version 7.0 of phpunit?:

        "phpunit/phpunit": "<6.0 || >=7.0"

There are a handful of phpunit releases above version 6.5 but lower than 7.0.

@Slamdunk
Copy link
Contributor Author

Slamdunk commented Feb 10, 2018

Omg, I'm sorry, I thought >6.5 meant >=6.6.0, I don't have my pc now, we need a bugfix soon :(

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants