Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: Select field breaks forms in safari #5685

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix: Select field breaks forms in safari #5685

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d94580e
Removes selection prop on select input on safari
gfviegas Mar 1, 2023
61f9287
Update src/components/primitives/Select/Select.tsx
gfviegas Mar 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/components/primitives/Select/Select.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,6 +154,8 @@ const Select = (
'shadow',
'opacity',
]);

const isSafari = Platform.OS === 'web' && window.safari
gfviegas marked this conversation as resolved.
Show resolved Hide resolved

const commonInput = (
<Input
Expand All @@ -172,6 +174,7 @@ const Select = (
isDisabled={isDisabled}
pointerEvents="none"
variant={variant}
selection={isSafari ? undefined : nonLayoutProps.selection}
/>
);

Expand Down