Handshake middleware for server #224
Conversation
Server/Type/WebSocketServer.php
Outdated
| @@ -89,7 +94,8 @@ public function __construct( | |||
| $originCheck, | |||
| TopicManager $topicManager, | |||
| ServerPushHandlerRegistry $serverPushHandlerRegistry, | |||
| LoggerInterface $logger = null | |||
| LoggerInterface $logger = null, | |||
| HandshakeMiddlewareRegistry $handshakeMiddlewareRegistry | |||
There was a problem hiding this comment.
Arguments with default values must be at the end of the argument list
|
Hey, Thank your for your contribution, could you open a PR on https://github.com/GeniusesOfSymfony/WebsocketAppDemo and target your branch via composer And add a sample handshake middleware then I can run integration against it. |
|
while I made the fix for the constructor and added middleware example to docs (HandshakeMiddleware.md) |
|
Staging branch |
|
Got this after composer install :
|
|
Sorry, l will look to it in a few days |
|
|
||
| $user = $accessToken->getUser(); | ||
| $token = new AnonymousToken( | ||
| $request->getQuery()->get('access_token'), |
There was a problem hiding this comment.
what if the request object is null? and what if the access token is given in header?
|
|
||
| /** | ||
| * @param HandshakeMiddlewareAbstract $middleware | ||
| * @throws \Exception |
|
@Prophet777 @pierre-tranchard |
|
@Prophet777 |
|
Yes sorry, I don't have time, I'll try to test this week end, i'm sorry :/ |
|
@Prophet777 ping |
Possibility to add own handshake middleware for ws server
For example, I made handshake with OAuth access token)