Fix reconnect on connection reset #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to the official documentation `fwrite`() returns `false` when encountering an error. In order to detect whether the connection was reset we should therefore check for `false` and not `0`.
|
Thanks! |
|
Tagged and released in 1.2.1
And that's why the package isn't completely abandoned. As long as those versions of the bundle are still supported I'll make sure that this package functions and take in bug fixes to keep it reliable, but new functionality or major updates aren't going to be added in at this point. |
|
Thanks. Much appreciated. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current check for detecting whether a reconnect is necessary does not work correctly.
According to the official documentation
fwrite() returnsfalsewhen encountering an error. In order to detect whether the connection was reset we should therefore check forfalseand not0.I am aware that this package is deprecated, but it is still a dependency of gos/web-socket-bundle 2.x and 3.x. Without this fix this package and therefore gos/web-socket-bundle's Pusher doesn't work reliably