Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Update requirements.txt #12432

Open
wants to merge 3 commits into
base: 4.1.x
Choose a base branch
from
Open

Update requirements.txt #12432

wants to merge 3 commits into from

Conversation

anjogu
Copy link

@anjogu anjogu commented Jul 22, 2024

updated dropbox to "dropbox==12.0.2" since "dropbox==111.36.02" fails to install in ubuntu 22.04

Checklist

Reviewing is a process done by project maintainers, mostly on a volunteer basis. We try to keep the overhead as small as possible and appreciate if you help us to do so by completing the following items. Feel free to ask in a comment if you have troubles with any of them.

For all pull requests:

  • Confirm you have read the contribution guidelines
  • You have sent a Contribution Licence Agreement (CLA) as necessary (not required for small changes, e.g., fixing typos in the documentation)
  • Make sure the first PR targets the master branch, eventual backports will be managed later. This can be ignored if the PR is fixing an issue that only happens in a specific branch, but not in newer ones.

The following are required only for core and extension modules (they are welcomed, but not required, for contrib modules):

  • There is a ticket in https://github.com/GeoNode/geonode/issues describing the issue/improvement/feature (a notable exemption is, changes not visible to end-users)
  • The issue connected to the PR must have Labels and Milestone assigned
  • PR for bug fixes and small new features are presented as a single commit
  • Commit message must be in the form "[Fixes #<issue_number>] Title of the Issue"
  • New unit tests have been added covering the changes, unless there is an explanation on why the tests are not necessary/implemented
  • This PR passes all existing unit tests (test results will be reported by travis-ci after opening this PR)
  • This PR passes the QA checks: black geonode && flake8 geonode
  • Commits changing the settings, UI, existing user workflows, or adding new functionality, need to include documentation updates
  • Commits adding new texts do use gettext and have updated .po / .mo files (without location infos)

Submitting the PR does not require you to check all items, but by the time it gets merged, they should be either satisfied or inapplicable.

anjogu added 2 commits July 22, 2024 12:25
update on dropbox version under branch 4.1.x
updated dropbox to "dropbox==12.0.2" since "dropbox==111.36.02" fails to install in ubuntu 22.04
Copy link

cla-bot bot commented Jul 22, 2024

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @anjogu on file. In order for us to review and merge your code, please contact the project maintainers to get yourself added.

Update requirements.txt
Copy link

cla-bot bot commented Jul 22, 2024

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @anjogu on file. In order for us to review and merge your code, please contact the project maintainers to get yourself added.

Copy link

codecov bot commented Jul 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.19%. Comparing base (6c9445b) to head (8e1002a).

Additional details and impacted files
@@            Coverage Diff             @@
##            4.1.x   #12432      +/-   ##
==========================================
- Coverage   61.44%   60.19%   -1.25%     
==========================================
  Files         839      839              
  Lines       51765    51765              
  Branches     6623     6623              
==========================================
- Hits        31807    31160     -647     
- Misses      18416    19071     +655     
+ Partials     1542     1534       -8     

@giohappy giohappy self-requested a review July 26, 2024 11:48
Copy link
Contributor

@giohappy giohappy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@anjogu please add it to setup.cfg too

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants