-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
[Fixes #12455] Map thumbnails extent always cover the whole globe #12460
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #12460 +/- ##
==========================================
- Coverage 64.16% 64.15% -0.01%
==========================================
Files 888 888
Lines 53465 53469 +4
Branches 6596 6598 +2
==========================================
- Hits 34304 34303 -1
+ Misses 17651 17649 -2
- Partials 1510 1517 +7 |
@mattiagiupponi the calculated box is wrong, as you can see from the thumbnail of this layer for Italy. I also verified the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comment about wrong calculated extent
…2460) * [Fixes #12455] Map thumbnails extent always cover the whole globe * [Fixes #12455] Map thumbnails extent always cover the whole globe * [Fixes #12455] Map thumbnails extent always cover the whole globe * Fixed bbox calculation and repositioned utils * [Fixes #12455] fix test --------- Co-authored-by: G. Allegri <giohappy@gmail.com> (cherry picked from commit 5bcbd82)
…2460) (#12588) * [Fixes #12455] Map thumbnails extent always cover the whole globe * [Fixes #12455] Map thumbnails extent always cover the whole globe * [Fixes #12455] Map thumbnails extent always cover the whole globe * Fixed bbox calculation and repositioned utils * [Fixes #12455] fix test --------- Co-authored-by: G. Allegri <giohappy@gmail.com> (cherry picked from commit 5bcbd82) Co-authored-by: mattiagiupponi <51856725+mattiagiupponi@users.noreply.github.com>
@mattiagiupponi @giohappy thanks ! |
Checklist
For all pull requests:
The following are required only for core and extension modules (they are welcomed, but not required, for contrib modules):
Submitting the PR does not require you to check all items, but by the time it gets merged, they should be either satisfied or inapplicable.