Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

feat(Ellipse): add ellipse basic object and function to compute intersections and distances with ellipse #1072

Open
wants to merge 10 commits into
base: next
Choose a base branch
from
Open

feat(Ellipse): add ellipse basic object and function to compute intersections and distances with ellipse #1072

wants to merge 10 commits into from

Conversation

BenPinet
Copy link
Member

No description provided.

@BenPinet BenPinet requested a review from BotellaA January 15, 2025 10:18
@BotellaA BotellaA requested a review from panquez January 15, 2025 10:26
BotellaA
BotellaA approved these changes Jan 15, 2025
View reviewed changes
Copy link
Member

@BotellaA BotellaA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe wait for @panquez test review

panquez
panquez approved these changes Jan 15, 2025
View reviewed changes
Copy link
Member

@panquez panquez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your tests are very basic but LGTM for the moment

include/geode/geometry/basic_objects/ellipse.hpp Outdated Show resolved Hide resolved
include/geode/geometry/basic_objects/ellipse.hpp Outdated Show resolved Hide resolved
include/geode/geometry/distance.hpp Outdated Show resolved Hide resolved
include/geode/geometry/intersection.hpp Outdated Show resolved Hide resolved
include/geode/geometry/intersection.hpp Outdated Show resolved Hide resolved
tests/geometry/test-distance.cpp Outdated Show resolved Hide resolved
tests/geometry/test-distance.cpp Outdated Show resolved Hide resolved
tests/geometry/test-distance.cpp Show resolved Hide resolved
src/geode/geometry/intersection.cpp Outdated Show resolved Hide resolved
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@BotellaA BotellaA BotellaA approved these changes

@panquez panquez panquez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BenPinet @BotellaA @panquez