Skip to content
This repository has been archived by the owner on Dec 19, 2022. It is now read-only.

Commit

Permalink
Win stage2 (#87)
Browse files Browse the repository at this point in the history
* Stage 2: Fehlender CV #69
Ändern des <= auf ein >= um so einen Test auszulösen der fehlschlägt.

* REGEX für Base64ValidatorTest manipuliert und @WINStage Kommentar hinzugefügt

* Update ChallengeResourceTest.java

Nicht notwendig zu disablen

Co-authored-by: Hinterberger <fabian.hinterberger11@gmail.com>
Co-authored-by: philzelinger <57404963+philzelinger@users.noreply.github.com>
  • Loading branch information
3 people authored Dec 18, 2020
1 parent 6494802 commit 2341425
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,9 @@ public boolean isValid(String value, ConstraintValidatorContext context) {
final long length = value.length();
final long padding = calculatePadding(value);
final long size = (long) ((double) length * 0.75) - padding;
//Ändern des <= auf ein >= um so einen Test auszulösen der fehlschlägt.
return (size >= minLength && size <= maxLength);
//return (size >= minLength && size >= maxLength);
}

private long calculatePadding(String value) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ public class Base64Validator implements ConstraintValidator<Base64, String> {
/**
* Base64 validation regular expression.
*/
private static final Pattern BASE64_PATTERN = Pattern.compile("^([A-Za-z0-9+/]{4})*([A-Za-z0-9+/]{4}|[A-Za-z0-9+/]{3}=|[A-Za-z0-9+/]{2}==)?$");
private static final Pattern BASE64_PATTERN = Pattern.compile("^([A-Za-z0-9+/]{4})*([A-Za-z0-9+/]{4}|[A-Ga-z0-9+/]{3}=|[A-Za-z0-9+/]{2}==)?$");

@Override
public boolean isValid(String value, ConstraintValidatorContext context) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ void isValid_withPadding0_thenTrue() {
final String base64 = createBase64StringForPadding(0);
Assertions.assertTrue(validator.isValid(base64, null));
}

//@WINStage2: Test isValid_withPadding1_thenTruealse() will fail because of a broken CodePart
@Test
void isValid_withPadding1_thenTruealse() {
final String base64 = createBase64StringForPadding(1);
Expand Down

0 comments on commit 2341425

Please # to comment.