Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Better schema integrity checks in tests #10

Merged
merged 3 commits into from
Sep 15, 2023
Merged

Better schema integrity checks in tests #10

merged 3 commits into from
Sep 15, 2023

Conversation

dafeder
Copy link
Member

@dafeder dafeder commented Dec 17, 2020

We were checking before if a schema would fail if it was invalid JSON, but not if it was valid JSON but broke the JSON schema spec.

paul-m
paul-m approved these changes Sep 15, 2023
View reviewed changes
Copy link
Contributor

@paul-m paul-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adds an important test case.

@paul-m paul-m changed the title Better schema integrity checks Better schema integrity checks in tests Sep 15, 2023
@paul-m paul-m merged commit 2c7152b into master Sep 15, 2023
@paul-m paul-m deleted the schema-validation branch September 15, 2023 20:15
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@paul-m paul-m paul-m approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dafeder @paul-m