Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix storybook so scss files work #132

Merged
merged 1 commit into from
Mar 3, 2021
Merged

Fix storybook so scss files work #132

merged 1 commit into from
Mar 3, 2021

Conversation

dgading
Copy link
Member

@dgading dgading commented Mar 3, 2021

Instead of just adding some loaders during the preview build, I copied the Webpack settings from the Storybook docs and put them in the module exports in main.js

To test, I have included a very basic story for Card component that uses USWDS classes. Just pull the code, install node modules and run npm run storybook and checkout the Card component.

@dgading dgading requested a review from alexiscott March 3, 2021 15:41
@dgading dgading added this to the v2.0.0 milestone Mar 3, 2021
@alexiscott
Copy link
Contributor

QA Pass! Builds locally.

@dgading dgading merged commit e1a768a into 2.x Mar 3, 2021
@dgading dgading deleted the fix-storybook branch June 28, 2021 14:31
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants