Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix failing tests #135

Merged
merged 8 commits into from
Mar 4, 2021
Merged

Fix failing tests #135

merged 8 commits into from
Mar 4, 2021

Conversation

dgading
Copy link
Member

@dgading dgading commented Mar 4, 2021

With the removal of enzyme some of our tests are failing. This PR will update those tests with a rough equivalent in testing-library to make it easier to add or update components during 2.x build.

@dgading dgading marked this pull request as draft March 4, 2021 21:14
@dgading dgading marked this pull request as ready for review March 4, 2021 23:07
@dgading dgading requested a review from brianseek March 4, 2021 23:07
@dgading dgading added this to the v2.0.0 milestone Mar 4, 2021
@brianseek brianseek merged commit 0257a05 into 2.x Mar 4, 2021
@dgading dgading deleted the fix-failing-tests branch June 28, 2021 14:31
dgading added a commit that referenced this pull request May 18, 2022
* Comment out datastore since it is not used

* Fix tests for DatatableDensity and SearchListItem

* Fix propTypes and tests for DataTablePageResults

* Add basic test to DatasetSearcCard

* Skip tests on navbar as component needs to be replaced with non Bootstrap

* Skip test as inputs are removed currently as they are being replaced with non bootstrap

* Skip and fix some toggle block tests

* Update or skip tests on Search Input, Result Message, and SHow more'
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants