Add update hook for 12.3+ patch upgrade. #1283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
REF CIVIC-3573 The 1.12.6 patch upgrades for out of the box sites has not been working as expected (tests are failing) because the new Markdown and role-assign features are not enabled or configured correctly. AC == - [ ] DKAN tests pass for Site upgrades with this patch combined with the patch to skip customizable tests.
dkinzer
force-pushed
the
civic-3573-add-updb-for-12.3-upgrade
branch
from
c0e693a to
75b27ae
Compare
| /** | ||
| * Configures BUEditor and markdown test format. | ||
| */ | ||
| function dkan_bueditor_markdown_install() { |
There was a problem hiding this comment.
@acouch this function doesn't make sense inside the profile. It only gets called by sites on updates not on first time installation.
There was a problem hiding this comment.
Ideally it would get called upon install as well as updates. As we add these functions I would think they would live in the dkan.profile.
|
Looks like we might actually still need this PR.. need to redo. |
|
Merged release-1-12 and resolved conflict. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
REF CIVIC-3573
The 12.6 patch upgrades for out of the box sites has not been working as
expected (tests are failing) because the new Markdown and role-assign features
are not enabled or configured correctly.
Acceptance Criteria
to skip customizable tests.