Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Make Dataset route and View perms match. #4396

Merged
merged 1 commit into from
Jan 28, 2025
Merged

Make Dataset route and View perms match. #4396

merged 1 commit into from
Jan 28, 2025

Conversation

swirtSJW
Copy link
Contributor

@swirtSJW swirtSJW commented Jan 28, 2025 •
edited
Loading

Fixes #4395

Describe your changes

Sets the View's access to be the same as the route.

QA Steps

  • grant a role a perm of create data content but NO perm of access content overview
  • login as a user with that role
  • validate you can get to /admin/dkan/datasets

Checklist before requesting review

If any of these are left unchecked, please provide an explanation

  • I have updated or added tests to cover my code
  • I have updated or added documentation

@swirtSJW swirtSJW marked this pull request as ready for review January 28, 2025 01:18
@swirtSJW swirtSJW requested a review from janette January 28, 2025 01:47
@swirtSJW swirtSJW self-assigned this Jan 28, 2025
@swirtSJW swirtSJW changed the title DKAN-4395 Make Dataset route and View perms match. Make Dataset route and View perms match. Jan 28, 2025
@janette janette merged commit 74510c1 into 2.x Jan 28, 2025
11 checks passed
@janette janette deleted the DKAN-4395-dataset-view-perms branch January 28, 2025 16:50
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@janette janette janette approved these changes

Assignees

@swirtSJW swirtSJW

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dual perms for Dataset View contradict each other.
2 participants
@swirtSJW @janette