Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Updates to datastore install to create a valid schema for post import… #4408

Merged
merged 2 commits into from
Feb 24, 2025

Conversation

kaise-lafrai
Copy link
Contributor

@kaise-lafrai kaise-lafrai commented Feb 18, 2025

… result table

Fixes #4407

Describe your changes

Checkout this branch : 2.x

  • run ddev dkan-site-install
  • run ddev drush sqlc then describe dkan_post_import_job_status; and confirm id and timestamp fields DO NOT exist.
  • running ddev drush updatedb DOES NOT do anything
  • checkout this branch datastore-install-updates
  • run ddev drush updatedb, confirm that datastore_update_9004 runs successfully.
  • run ddev drush sqlc then describe dkan_post_import_job_status; and confirm id and timestamp fields exist.
  • run through creating datasets and applying data dictionaries.
  • confirm dashboard reflects the correct post import status at /admin/dkan/datastore/status

Checkout this branch: datastore-install-updates

  • run ddev dkan-site-install
  • run ddev drush sqlc then describe dkan_post_import_job_status; and confirm id and timestamp fields exist.
  • run through creating datasets and applying data dictionaries.
  • confirm dashboard reflects the correct post import status at /admin/dkan/datastore/status

Checklist before requesting review

If any of these are left unchecked, please provide an explanation

  • I have updated or added tests to cover my code
  • I have updated or added documentation

@kaise-lafrai kaise-lafrai marked this pull request as ready for review February 19, 2025 17:30
Copy link
Member

@janette janette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@dafeder dafeder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just noting that this is mysql-only code in the update hook. That's fine for now, update is not used for kernel tests so anything created temporarily in SQLite will be ok; a bunch of other places in the datastore also break on non-MySQL backends. Some day would be good to abstract this so its PostgreSQL and SQLite-compatible but not today :)

@dafeder dafeder merged commit 010600b into 2.x Feb 24, 2025
11 checks passed
@dafeder dafeder deleted the datastore-install-updates branch February 24, 2025 16:26
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fresh install does not create new columns for the dkan_post_import_job_status table
3 participants