Refactor DrupalFiles to remove deprecated system_retrieve_file() #4420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dafeder
force-pushed
the
system-retrieve-file2
branch
from
5c5fb38 to
846e68d
Compare
dafeder
commented
Feb 27, 2025
| @@ -98,7 +123,65 @@ public function retrieveFile($url, $destination) { | |||
| return $this->fileCreateUrl("{$destination}/{$filename}"); | |||
| } | |||
| // Handle http(s):// URIs. | |||
| return system_retrieve_file($url, $destination, FALSE, FileSystemInterface::EXISTS_REPLACE); | |||
| return $this->retrieveRemoteFile($url, $destination); | |||
There was a problem hiding this comment.
Because this is the only call to system_retrieve_file(), and we always pass it false for managed and replace for file exists, we don't need to support parameters for this. Meaning we don't need to have any support at all for managed files in this class.
paul-m
approved these changes
Feb 28, 2025
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #4368
Continuing work on #4283 by @paul-m
Note that all logic dealing with managed files is removed. In the old DrupalFiles, $managed was always passed as FALSE, so there was no way files would ever be managed.
Describe your changes
Refactors our code to not use
system_retrieve_file().Required for Drupal 11.
Change record: https://www.drupal.org/node/3223362