refactor: do not allow to set active state on search source initiation

GetStream · Jan 31, 2025 · e145dae · e145dae
1 parent a2c8fec
commit e145dae
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 6 deletions.
diff --git a/src/search_controller.ts b/src/search_controller.ts
@@ -62,13 +62,11 @@ export type SearchSourceState<T = any> = {
 export type SearchSourceOptions = {
   /** The number of milliseconds to debounce the search query. The default interval is 300ms. */
   debounceMs?: number;
-  isActive?: boolean;
   pageSize?: number;
 };
 
 const DEFAULT_SEARCH_SOURCE_OPTIONS: Required<SearchSourceOptions> = {
   debounceMs: 300,
-  isActive: false,
   pageSize: 10,
 } as const;
 
@@ -79,9 +77,9 @@ export abstract class BaseSearchSource<T> implements SearchSource<T> {
   searchDebounced!: DebouncedExecQueryFunction;
 
   protected constructor(options?: SearchSourceOptions) {
-    const { debounceMs, isActive, pageSize } = { ...DEFAULT_SEARCH_SOURCE_OPTIONS, ...options };
+    const { debounceMs, pageSize } = { ...DEFAULT_SEARCH_SOURCE_OPTIONS, ...options };
     this.pageSize = pageSize;
-    this.state = new StateStore<SearchSourceState<T>>({ ...this.initialState, isActive });
+    this.state = new StateStore<SearchSourceState<T>>(this.initialState);
     this.setDebounceOptions({ debounceMs });
   }
 

diff --git a/test/unit/search_controller.test.js b/test/unit/search_controller.test.js
@@ -268,9 +268,8 @@ describe('BaseSearchSource and implementations', () => {
 		});
 
 		it('initializes with custom options', () => {
-			searchSource = new TestSearchSource({ pageSize: 20, isActive: true });
+			searchSource = new TestSearchSource({ pageSize: 20 });
 			expect(searchSource.pageSize).to.equal(20);
-			expect(searchSource.isActive).to.be.true;
 		});
 
 		describe('activate/deactivate', () => {