feat: support campaign user pagination #1462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kanat
requested review from
vishalnarkhede,
santhoshvai,
khushal87,
szuperaz,
oliverlaz,
arnautov-anton,
MartinCupela and
myandrienko
as code owners
kanat
changed the title
|
Size Change: +72 B (+0.01%) Total Size: 525 kB
|
kanat
changed the title
myandrienko
reviewed
Feb 3, 2025
MartinCupela
reviewed
Feb 4, 2025
MartinCupela
reviewed
Feb 4, 2025
MartinCupela
reviewed
Feb 4, 2025
MartinCupela
reviewed
Feb 4, 2025
| { | ||
| campaign: CampaignResponse; | ||
| users: { | ||
| next?: string; |
There was a problem hiding this comment.
What are the returned cursors for when creating a campaign?
There was a problem hiding this comment.
If you pass more than 1,000 user_ids when creating a campaign, then in response you'll still get only 1,000 users with pager token
There was a problem hiding this comment.
And when do you get next and prev?
|
@kanat I could not find any topic-related docs at https://github.com/GetStream/docs-content/pulls/kanat. Do you plan to add some? |
|
Hey @MartinCupela, thank you for the feedback 👍 Yup, I add the docs changes by Today. |
|
@MartinCupela the PR for docs is here: |
MartinCupela
approved these changes
Feb 24, 2025
github-actions bot
pushed a commit
that referenced
this pull request
Feb 26, 2025
## [8.57.0](v8.56.1...v8.57.0) (2025-02-26) ### Features * add option to override channel.updated handler in ChannelManager ([#1471](#1471)) ([9082084](9082084)) * expand campaign stats ([#1470](#1470)) ([cc6404c](cc6404c)) * support campaign user pagination ([#1462](#1462)) ([c629018](c629018)) * support new X-Stream-Client format ([#1469](#1469)) ([fdb875b](fdb875b))
|
🎉 This PR is included in version 8.57.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
arnautov-anton
pushed a commit
that referenced
this pull request
Feb 27, 2025
## [8.57.0](v8.56.1...v8.57.0) (2025-02-26) ### Features * add option to override channel.updated handler in ChannelManager ([#1471](#1471)) ([9082084](9082084)) * expand campaign stats ([#1470](#1470)) ([cc6404c](cc6404c)) * support campaign user pagination ([#1462](#1462)) ([c629018](c629018)) * support new X-Stream-Client format ([#1469](#1469)) ([fdb875b](fdb875b))
Merged
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
Related PR
CLA
Description of the changes, What, Why and How?
Changelog