Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: pin preferredAssetRepresentationMode to current #2979

Merged
merged 1 commit into from
Feb 25, 2025

Conversation

isekovanic
Copy link
Contributor

🎯 Goal

Zendesk ticket: https://getstream.zendesk.com/agent/tickets/61817

Whenever we set access to the native image picker as Limit Access and try to upload a very large video (above the 100mb threshold), the Alert telling us that we cannot upload the file comes in after a very long time (above 10 seconds).

This is due to the fact that iOS has a compression mechanism in place that unfortunately expo-image-picker waits for. On Android, it's a similar issue (albeit not reproducible on every device), but related to copying the file elsewhere in the system. Unfortunately there is no workaround for Android provided by the library.

This also means that for iOS we will not have implicit compression in place. As an alternative, integrators can implement pickImage on their own if none of these fixes resolve their issues.

🛠 Implementation details

🎨 UI Changes

iOS
Before After
Android
Before After

🧪 Testing

☑️ Checklist

  • I have signed the Stream CLA (required)
  • PR targets the develop branch
  • Documentation is updated
  • New code is tested in main example apps, including all possible scenarios
    • SampleApp iOS and Android
    • Expo iOS and Android

@isekovanic isekovanic requested a review from oliverlaz February 24, 2025 22:29
@Stream-SDK-Bot
Copy link
Contributor

SDK Size

title develop branch diff status
js_bundle_size 468 KB 468 KB 0 B 🟢

@isekovanic isekovanic merged commit bc3b539 into develop Feb 25, 2025
5 checks passed
@isekovanic isekovanic deleted the fix/expo-image-picker-slow-file-callback branch February 25, 2025 11:37
@github-actions github-actions bot mentioned this pull request Feb 25, 2025
6 tasks
@stream-ci-bot
Copy link
Contributor

🎉 This PR is included in version 6.6.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants