Skip to content

Disable caching for author in message list #540

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Jul 10, 2024

Conversation

laevandus
Copy link
Contributor

@laevandus laevandus commented Jul 10, 2024

🔗 Issue Link

Related PBE-4291

🎯 Goal

We have list reusing and background mapping enabled on the LLC side. Therefore, it not needed to cache the access to author. Caching had side effects like avatars and names not updating when accessed through ChatMessage userDisplayInfo(from:).
Profiled it and author access did not show up as expected.

☑️ Checklist

  • I have signed the Stream CLA (required)
  • Changelog is updated with client-facing changes
  • New code is covered by unit tests
  • Affected documentation updated (docusaurus, tutorial, CMS (task created)

@laevandus laevandus added bug Something isn't working swiftui-repo labels Jul 10, 2024
@laevandus laevandus requested a review from a team as a code owner July 10, 2024 07:57
Copy link

@martinmitrevski martinmitrevski merged commit fa94428 into develop Jul 10, 2024
10 checks passed
@martinmitrevski martinmitrevski deleted the fix/author-without-caching branch July 10, 2024 08:56
@martinmitrevski martinmitrevski mentioned this pull request Jul 10, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working swiftui-repo
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants