Typing users did not update reliably in the message list #591
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… model did not propagate channel changes to the view
SDK Size
|
|
|
@testableapple and I did a manual testing together. |
testableapple
approved these changes
Aug 29, 2024
Merged
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Issue Link
Resolves: PBE-5805
🎯 Goal
🛠 Implementation
After verifying that LLC correctly propagates the typing users change and ChatChannelController.channel returning multiple users the issue had to be on the view side. The issue is that when channel changes,
ChatChannelViewModeldoes not propagate the change and SwiftUI view did not know that it needs to redisplay.🧪 Testing
Result: on the third device we see typing indicator saying user x and 1 more are typing
☑️ Checklist