Channel was sometimes marked as read on open #593
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Issue Link
Resolves: PBE-5810
🎯 Goal
Fix the issue or marking a channel as read when the first unread message was one of the first not visible messages
🛠 Implementation
The fix is a workaround to the SwiftUI issue where the LazyVStack pushed to the NavigationStack has initially larger height and therefore trigger onAppear for more messages than it should. This causes
ChatChannelViewModel
to mark the channel as read because it thinks the user also saw the first unread message. Apple's feedback id is: FB15010770.🧪 Testing
Before: Unread message pill appeared for a split second and the channel was marked as read
Expected: Unread message pill appears at the top of the channel view.
🎨 Changes
Note how in the before video the second opening on the channel marked it as read (the pill went away).
☑️ Checklist