-
Notifications
You must be signed in to change notification settings - Fork 101
Channel was sometimes not selected when setting selectedChannelId #611
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…annelId was set to a channel created a moments ago
SDK Size
|
martinmitrevski
approved these changes
Sep 30, 2024
|
Merged
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Issue Link
Resolves: PBE-6078
🎯 Goal
Fix an issue where creating the channel list view with
selectedChannelId
set to a channel created a moments ago, did not select it.🛠 Implementation
If there are integrations where a separate backend is used for creating channels and API responses contain cids, then immediately creating a channel list view and setting the selected id might fail. SDK needs to receive a web-socket event which triggers channel list change (calling synchronize can be too soon as well). Therefore, this PR changes the way how we try to set selected channel to waiting channel list updates instead. Moreover, it clarifies that the
selectedChannelId
method only works for loaded channels and it might be better to useChannelViewScreen
instead when it is certain that the channel is not part of the loaded list.🧪 Testing
Since the issue is around timing with other backend APIs, it is hard to manually test.
☑️ Checklist