Skip to content

Quoted message preview did not update when the quoted message was deleted #705

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 9, 2025
Merged

Quoted message preview did not update when the quoted message was deleted #705

merged 3 commits into from
Jan 9, 2025

Conversation

laevandus
Copy link
Contributor

@laevandus laevandus commented Jan 8, 2025 •
edited
Loading

🔗 Issue Link

Resolves IOS-478

🎯 Goal

Fix an issue with refreshing quoted message previews when it was deleted

🛠 Implementation

  • StreamChat brings the DB level fix
  • Fix the quoted message text for deleted messages (use textContent)
  • Set text color to low emphasis

🧪 Testing

  1. Send a message
  2. Use the reply action and send a reply
  3. Delete the message in the step 1 > message in the step 2 updates

🎨 Changes

Before After
Before After

☑️ Checklist

  • I have signed the Stream CLA (required)
  • Changelog is updated with client-facing changes
  • New code is covered by unit tests
  • Affected documentation updated (docusaurus, tutorial, CMS (task created)

@laevandus laevandus requested a review from a team as a code owner January 8, 2025 11:56
@laevandus laevandus force-pushed the fix/quoted-message-refresh branch from 41752fc to 710f753 Compare January 8, 2025 12:00
@Stream-SDK-Bot
Copy link
Collaborator

Stream-SDK-Bot commented Jan 8, 2025 •
edited
Loading

SDK Size

title develop branch diff status
StreamChatSwiftUI 7.53 MB 7.54 MB +1 KB 🟢

nuno-vieira
nuno-vieira approved these changes Jan 8, 2025
View reviewed changes
Copy link
Member

@nuno-vieira nuno-vieira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ✅

laevandus
laevandus commented Jan 9, 2025
View reviewed changes
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jan 9, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
49.2% Coverage on New Code (required ≥ 70%)

See analysis details on SonarQube Cloud

@laevandus laevandus merged commit c8d0660 into develop Jan 9, 2025
11 of 12 checks passed
@laevandus laevandus deleted the fix/quoted-message-refresh branch January 9, 2025 20:09
@Stream-SDK-Bot Stream-SDK-Bot mentioned this pull request Jan 15, 2025
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@martinmitrevski martinmitrevski martinmitrevski approved these changes

@nuno-vieira nuno-vieira nuno-vieira approved these changes

@testableapple testableapple testableapple approved these changes

Assignees
No one assigned
Labels
✅ QAed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@laevandus @Stream-SDK-Bot @martinmitrevski @nuno-vieira @testableapple