Skip to content

Customizing the message avatar view is reflected in all views that use it #772

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 4 commits into from
Mar 6, 2025

Conversation

martinmitrevski
Copy link
Contributor

🔗 Issue Link

Resolves https://linear.app/stream/issue/IOS-727/polls-views-are-not-using-avatar-factory-methods.

🎯 Goal

Another option is to introduce new factory method.

🛠 Implementation

Provide a description of the implementation.

🧪 Testing

Describe the steps how this change can be tested (or why it can't be tested).

🎨 Changes

Add relevant screenshots or videos showcasing the changes.

☑️ Checklist

  • I have signed the Stream CLA (required)
  • Changelog is updated with client-facing changes
  • New code is covered by unit tests
  • Affected documentation updated (docusaurus, tutorial, CMS (task created)

@martinmitrevski martinmitrevski requested a review from a team as a code owner March 4, 2025 22:53
@martinmitrevski martinmitrevski marked this pull request as draft March 4, 2025 22:53
@Stream-SDK-Bot
Copy link
Collaborator

Stream-SDK-Bot commented Mar 4, 2025

SDK Size

title develop branch diff status
StreamChatSwiftUI 8.19 MB 8.16 MB -29 KB 🚀

Copy link
Contributor

@laevandus laevandus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it makes sense to reuse the factory method. Leaving my approval here although it is in the draft state.

Copy link
Member

@nuno-vieira nuno-vieira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ✅

@martinmitrevski martinmitrevski changed the title Avatars in polls customized with the factory method Customizing the message avatar view is reflected in all views that use it Mar 6, 2025
@martinmitrevski martinmitrevski marked this pull request as ready for review March 6, 2025 01:01
@martinmitrevski martinmitrevski enabled auto-merge (squash) March 6, 2025 17:34
@martinmitrevski martinmitrevski merged commit ac7fd36 into develop Mar 6, 2025
12 checks passed
@martinmitrevski martinmitrevski deleted the polls-message-avatar branch March 6, 2025 17:40
@Stream-SDK-Bot Stream-SDK-Bot mentioned this pull request Mar 14, 2025
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants