Remove Java custom armor trims when translating item to Bedrock to pr…

…event visual issues (#4548)

* Fix (or workaround) armor items with custom armor trims having no texture on bedrock

* Fix armor items with custom trims causing issues on entity models by removing the Trim tag entirely

* Refer to minecraft namespace inline for consistency

core/src/main/java/org/geysermc/geyser/item/type/ArmorItem.java

@@ -47,6 +47,14 @@ public void translateNbtToBedrock(@NonNull GeyserSession session, @NonNull Compo
         if (tag.get("Trim") instanceof CompoundTag trim) {
             StringTag material = trim.remove("material");
             StringTag pattern = trim.remove("pattern");
+
+            // discard custom trim patterns/materials to prevent visual glitches on bedrock
+            if (!material.getValue().startsWith("minecraft:")
+                    || !pattern.getValue().startsWith("minecraft:")) {
+                tag.remove("Trim");
+                return;
+            }
+
             // bedrock has an uppercase first letter key, and the value is not namespaced
             trim.put(new StringTag("Material", stripNamespace(material.getValue())));
             trim.put(new StringTag("Pattern", stripNamespace(pattern.getValue())));