-
-
Notifications
You must be signed in to change notification settings - Fork 709
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Fix for plugins that use display entities as nametag #5157
Conversation
core/src/main/java/org/geysermc/geyser/entity/type/TextDisplayEntity.java
Outdated
Show resolved
Hide resolved
Removed useless offset
core/src/main/java/org/geysermc/geyser/entity/type/TextDisplayEntity.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hopefully this removes the private Component text
as we don't seem to need it stored anywhere. Feel free to correct me if I'm wrong.
core/src/main/java/org/geysermc/geyser/entity/type/TextDisplayEntity.java
Outdated
Show resolved
Hide resolved
core/src/main/java/org/geysermc/geyser/entity/type/TextDisplayEntity.java
Outdated
Show resolved
Hide resolved
Is there something else you want me to change? I'd like to push an update for my plugin that adds support for bedrock but I'm waiting for this pr. |
Removed space
Just tested and it's fine for me, thanks |
Implemented a simple formula that calculates y offset based on the lines the display entity has. It's not perfect for higher values but for values up to 4/5 is close to vanilla.