Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix for plugins that use display entities as nametag #5157

Merged
merged 7 commits into from
Dec 15, 2024

Conversation

alexdev03
Copy link
Contributor

Implemented a simple formula that calculates y offset based on the lines the display entity has. It's not perfect for higher values but for values up to 4/5 is close to vanilla.

image
image

rtm516
rtm516 previously requested changes Nov 22, 2024
Copy link
Member

@rtm516 rtm516 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hopefully this removes the private Component text as we don't seem to need it stored anywhere. Feel free to correct me if I'm wrong.

@alexdev03
Copy link
Contributor Author

Is there something else you want me to change? I'd like to push an update for my plugin that adds support for bedrock but I'm waiting for this pr.
If you want to test this pr you could use my plugin, branch dev: https://github.com/alexdev03/UnlimitedNametags

@Tim203
Copy link
Member

Tim203 commented Dec 14, 2024

Alright so I had a bit of time to do some testing and I noticed that Bedrock's nametag offset doesn't match Java's:
image
image
Bedrock seems to have more distance between the head and the nametag. Because of this, I think it's better to follow Bedrock's distance here instead of trying to get it as close as Java.
I've played around with the values a bit and I think the one I ended up using is pretty good.
image
image
I'm going to push the changes to your branch in a bit and feel free to try them out. If you're ok with those change I'll merge this PR.

@alexdev03
Copy link
Contributor Author

Just tested and it's fine for me, thanks

@Tim203 Tim203 merged commit 54bdb63 into GeyserMC:master Dec 15, 2024
2 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants