Feature/1.21.4 #5178
Merged
Feature/1.21.4 #5178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… additional and base component
onebeastchris
added
Work in Progress
…ure/1.21.4 # Conflicts: # core/src/main/java/org/geysermc/geyser/translator/inventory/LecternInventoryTranslator.java
…tiers, deprecate repair items and tool tier in NonVanillaCustomItemData
…ure/1.21.4 # Conflicts: # gradle.properties
onebeastchris
added
PR: Feature
…ure/1.21.4 # Conflicts: # core/src/main/java/org/geysermc/geyser/registry/populator/BlockRegistryPopulator.java # core/src/main/java/org/geysermc/geyser/registry/populator/ItemRegistryPopulator.java # gradle/libs.versions.toml
Closed
onebeastchris
added
the
PR: Needs Testing
Camotoy
reviewed
Dec 7, 2024
core/src/main/java/org/geysermc/geyser/entity/type/living/monster/CreakingEntity.java
Outdated
Show resolved
Hide resolved
Camotoy
reviewed
Dec 7, 2024
core/src/main/java/org/geysermc/geyser/inventory/updater/AnvilInventoryUpdater.java
Outdated
Show resolved
Hide resolved
Camotoy
reviewed
Dec 7, 2024
core/src/main/java/org/geysermc/geyser/translator/inventory/LoomInventoryTranslator.java
Outdated
Show resolved
Hide resolved
…y possible combinations, update adapters
This was
linked to
issues
Dec 9, 2024
…'t throw due to duplicate keys
…utomatically check for the required version
…for attribute modifiers (#5211)
|
How long until this pr is prod ready |
|
You can already use it fine - the only thing that's currently still not quite there are block breaking animations for other players, but those are only visual anyways. |
|
Anyone able to make a .jar of this? |
|
To access build artifacts, you can click on "Checks" at the top of this pull request, then click on "Artifacts"
|
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Opening a PR to track to-do's.
TODO:
Left to implement:
- [ ] repair cost is a component too! https://github.com/GeyserMC/MCProtocolLib/blob/9332151a49e38a9705998609075a8a8c8a887903/protocol/src/main/java/org/geysermc/mcprotocollib/protocol/data/game/item/component/DataComponentType.java#L41will deal with in separate PROther:
Needs testing: